hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Arpit Agarwal (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-10565) Support IP ranges (CIDR) in proxyuser.hosts
Date Fri, 27 Jun 2014 07:37:25 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-10565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Arpit Agarwal updated HADOOP-10565:
-----------------------------------

    Attachment: HADOOP-10565.06.patch

+1 for the patch, thanks Benoy!

I took the liberty of making a few trivial formatting changes.

{code}
@@ -108,12 +108,12 @@ public MachineList(Collection<String> hostEntries, InetAddressFactory
           } else if (InetAddresses.isInetAddress(hostEntry)) { //ip address
             ips.add(hostEntry);
           } else { //hostname
-              hosts.add(hostEntry);
+            hosts.add(hostEntry);
           }
         }
-        ipAddresses = (ips.size() > 0)?ips:null;
-        cidrAddresses = (cidrs.size() > 0)?cidrs:null;
-        hostNames = (hosts.size() > 0)?hosts:null;
+        ipAddresses = (ips.size() > 0) ? ips : null;
+        cidrAddresses = (cidrs.size() > 0) ? cidrs : null;
+        hostNames = (hosts.size() > 0) ? hosts : null;
{code}

and

{code}
@@ -182,7 +182,7 @@ public boolean includes(String ipAddress) {
    */
   @VisibleForTesting
   public Collection<String> getCollection() {
-    Collection<String>  list = new ArrayList<String>();
+    Collection<String> list = new ArrayList<String>();
{code}

Updated patch attached. I will commit it shortly.

> Support IP ranges (CIDR) in  proxyuser.hosts
> --------------------------------------------
>
>                 Key: HADOOP-10565
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10565
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: HADOOP-10565.06.patch, HADOOP-10565.patch, HADOOP-10565.patch, HADOOP-10565.patch,
HADOOP-10565.patch, HADOOP-10565.patch
>
>
> In some use cases, there will be many hosts from which the user can impersonate. 
> This requires specifying many ips  in the XML configuration. 
> It is cumbersome to specify and maintain long list of ips in proxyuser.hosts
> The problem can be solved if we enable proxyuser.hosts to accept ip ranges in CIDR format.
> In addition, the current ip authorization involve a liner scan of the ips and an attempt
to do InetAddress.getByName()  for each ip/host. 
> It may be beneficial to group this functionality of ip authorization by looking up  "ip
addresses/host names/ip-ranges" into a separate class. This could be reused in other usecases
which require similar functionality



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message