hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-10420) Add support to Swift-FS to support tempAuth
Date Fri, 06 Jun 2014 19:04:02 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steve Loughran updated HADOOP-10420:
------------------------------------

    Attachment: HADOOP-10420-002.patch

I've had a quick look at the code and am handing back a slightly modified version for you
to work on until it's ready to be committed. 

1. I renamed SoftLayer references to TempAuth.
2. I pulled the new GET auth into its own method, {{TempAuthGet}}, where I have some questions

{{getAllowedStatusCodes()}}: why are those the allowed status codes? And if so, why ?

{{extractResult()}}
- A null object location URI is always produced. But A lot of code depends on it being non-null,
because its   how the path to objects are found. It needs to be set to *something*.

-There's some exception swallowing at the log level. If something went wrong, the operation
should fail early  with meaningful messages, rather than at some random point later. I've
added a couple of exception creation to where exceptions were being swallowed -review them
to see if there is a better action.
   
-There's some flows of response that aren't handled here. 
-# what if NO auth headers come in? That should be a failure, surely?
-# what if two auth headers come in? Is that OK to ignore?

> Add support to Swift-FS to support tempAuth
> -------------------------------------------
>
>                 Key: HADOOP-10420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10420
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs, fs/swift, tools
>    Affects Versions: 2.3.0
>            Reporter: Jinghui Wang
>         Attachments: HADOOP-10420-002.patch, HADOOP-10420.patch
>
>
> Currently, hadoop-openstack Swift FS supports keystone authentication. The attached patch
adds support for tempAuth. Users will be able to configure which authentication to use.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message