hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9559) When metrics system is restarted MBean names get incorrectly flagged as dupes
Date Fri, 20 Jun 2014 02:48:26 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038299#comment-14038299
] 

Hadoop QA commented on HADOOP-9559:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12651576/HADOOP-9559.2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4119//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4119//console

This message is automatically generated.

> When metrics system is restarted MBean names get incorrectly flagged as dupes
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-9559
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9559
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mostafa Elhemali
>         Attachments: HADOOP-9559.2.patch, HADOOP-9559.patch
>
>
> In the Metrics2 system, every source gets registered as an MBean name, which gets put
into a unique name pool in the singleton DefaultMetricsSystem object. The problem is that
when the metrics system is shutdown (which unregisters the MBeans) this unique name pool is
left as is, so if the metrics system is started again every attempt to register the same MBean
names fails (exception is eaten and a warning is logged).
> I think the fix here is to remove the name from the unique name pool if an MBean is unregistered,
since it's OK at this point to add it again.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message