Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Sat, 24 May 2014 02:41:01 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12715926.1400735888761.13126.1400899261686@arcas>
In-Reply-To: <JIRA.12715926.1400735888761@arcas>
References: <JIRA.12715926.1400735888761@arcas>
Subject: [jira] [Commented] (HADOOP-10625) Configuration: names should be
 trimmed when putting/getting to properties
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14007971#comment-14007971 ] 

Hadoop QA commented on HADOOP-10625:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12646182/HADOOP-10625.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3964//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3964//console

This message is automatically generated.

> Configuration: names should be trimmed when putting/getting to properties
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-10625
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10625
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: conf
>    Affects Versions: 2.4.0
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: HADOOP-10625.patch
>
>
> Currently, Hadoop will not trim name when putting a pair of k/v to property. But when loading configuration from file, names will be trimmed:
> (In Configuration.java)
> {code}
>           if ("name".equals(field.getTagName()) && field.hasChildNodes())
>             attr = StringInterner.weakIntern(
>                 ((Text)field.getFirstChild()).getData().trim());
>           if ("value".equals(field.getTagName()) && field.hasChildNodes())
>             value = StringInterner.weakIntern(
>                 ((Text)field.getFirstChild()).getData());
> {code}
> With this behavior, following steps will be problematic:
> 1. User incorrectly set " hadoop.key=value" (with a space before hadoop.key)
> 2. User try to get "hadoop.key", cannot get "value"
> 3. Serialize/deserialize configuration (Like what did in MR)
> 4. User try to get "hadoop.key", can get "value", which will make inconsistency problem.


--
This message was sent by Atlassian JIRA
(v6.2#6252)