Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Mon, 5 May 2014 06:04:15 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12709052.1397743053999.228655.1399269855234@arcas>
In-Reply-To: <JIRA.12709052.1397743053999@arcas>
References: <JIRA.12709052.1397743053999@arcas>
Subject: [jira] [Commented] (HADOOP-10517) InputStream is not closed in two
 methods of JarFinder
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989302#comment-13989302 ] 

Ted Yu commented on HADOOP-10517:
---------------------------------

The reason that patch v2 doesn't work is that ZipOutputStream#closeEntry() should be called instead of ZipOutputStream#close().
See:
http://docs.oracle.com/javase/6/docs/api/java/util/zip/ZipOutputStream.html#closeEntry()

IOUtils.closeQuietly() calls close() method.

> InputStream is not closed in two methods of JarFinder
> -----------------------------------------------------
>
>                 Key: HADOOP-10517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10517
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10517.1.patch.txt, hadoop-10517-v1.txt, hadoop-10517-v2.txt
>
>
> JarFinder#jarDir() and JarFinder#zipDir() have such code:
> {code}
>                  InputStream is = new FileInputStream(f);
>                  copyToZipStream(is, anEntry, zos);
> {code}
> The InputStream is closed in copyToZipStream() but should be enclosed in finally block.


--
This message was sent by Atlassian JIRA
(v6.2#6252)