hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Lamb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10635) Add a method to CryptoCodec to generate SRNs for IV
Date Thu, 29 May 2014 15:19:03 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012441#comment-14012441
] 

Charles Lamb commented on HADOOP-10635:
---------------------------------------

In general this looks good. I have a few little nits. For ternary constructs, I believe the
standard is to put the ? and : at the end of the line rather than the start of the line below.
 So,

thing ?
yes :
no;

s/jce/JCE/

In generateSecureRandom, byte[] data could benefit from a final.

It's a shame that HadoopIllegalArgumentException can't be used to wrap the GeneralSecurityException.
Do you want to take the exception message from the GSE and include it in the HIAE message
text to give the user some idea of what may be going on?


> Add a method to CryptoCodec to generate SRNs for IV
> ---------------------------------------------------
>
>                 Key: HADOOP-10635
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10635
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
>            Reporter: Alejandro Abdelnur
>            Assignee: Yi Liu
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-10635.patch
>
>
> SRN generators are provided by crypto libraries. the CryptoCodec gives access to a crypto
library, thus it makes sense to expose the SRN generator on the CryptoCodec API.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message