hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yi Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-10603) Crypto input and output streams implementing Hadoop stream interfaces
Date Fri, 23 May 2014 14:37:03 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-10603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yi Liu updated HADOOP-10603:
----------------------------

    Attachment: HADOOP-10603.10.patch

Hi [~andrew.wang], the new patch includes update for  your and [~clamb]’s new comments and
the left comments last time.  Thanks for your nice review :-). If I miss something, please
remind me.
Furthermore, I clarify following items:

{quote}
An ASCII art diagram showing how padding and the stream offset works would also be nice. Javadoc
for the special padding handling would be nice.
{quote}
I add more comments for padding handling. 

{quote}
We need to return -1 on EOF for zero-byte reads, see HDFS-5762.
{quote}
We have already handled this, and the new patch includes a test to verify return -1 on EOF
for zero-byte reads.
 


{quote}
Could also do some basic Precondition validation on the config parameters.
{quote}
Which parameter?  Buffer size?  If so, we add a precondition in the new patch.

{quote}
getDataLen() is never used
{quote}
{{getDataLen()}} is used by {{TestHdfsCryptoStreams}} in HDFS-6405


> Crypto input and output streams implementing Hadoop stream interfaces
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-10603
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10603
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
>            Reporter: Alejandro Abdelnur
>            Assignee: Yi Liu
>             Fix For: fs-encryption (HADOOP-10150 and HDFS-6134)
>
>         Attachments: CryptoInputStream.java, CryptoOutputStream.java, HADOOP-10603.1.patch,
HADOOP-10603.10.patch, HADOOP-10603.2.patch, HADOOP-10603.3.patch, HADOOP-10603.4.patch, HADOOP-10603.5.patch,
HADOOP-10603.6.patch, HADOOP-10603.7.patch, HADOOP-10603.8.patch, HADOOP-10603.9.patch, HADOOP-10603.patch
>
>
> A common set of Crypto Input/Output streams. They would be used by CryptoFileSystem,
HDFS encryption, MapReduce intermediate data and spills. Note we cannot use the JDK Cipher
Input/Output streams directly because we need to support the additional interfaces that the
Hadoop FileSystem streams implement (Seekable, PositionedReadable, ByteBufferReadable, HasFileDescriptor,
CanSetDropBehind, CanSetReadahead, HasEnhancedByteBufferAccess, Syncable, CanSetDropBehind).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message