hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10541) InputStream in MiniKdc#initKDCServer for minikdc.ldiff is not closed
Date Mon, 05 May 2014 19:31:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989875#comment-13989875
] 

Chris Nauroth commented on HADOOP-10541:
----------------------------------------

That's no problem.  Thank you for contributing a patch.  These little nitpick things are easy
to address in review.  :-)

Unfortunately, I can't help you with advice on an Eclipse formatter, because I don't use Eclipse.
 Maybe another community member who does use Eclipse will chime in.  We also have this page:

https://wiki.apache.org/hadoop/CodeReviewChecklist

Our stated standard is "follows Sun's code conventions except indentation is 2 spaces, not
4".  Maybe it's sufficient simply to clone the default formatting profile you get with Eclipse
and then switch the indentation to 2 spaces/no tabs.  I seem to recall from my Eclipse days
that there are 2 places you need to configure this: one setting for the number of spaces and
another setting for using space characters instead of tab characters.

> InputStream in MiniKdc#initKDCServer for minikdc.ldiff is not closed
> --------------------------------------------------------------------
>
>                 Key: HADOOP-10541
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10541
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Ted Yu
>            Assignee: Swarnim Kulkarni
>            Priority: Minor
>         Attachments: HADOOP-10541.1.patch.txt, HADOOP-10541.2.patch.txt, HADOOP-10541.3.patch.txt,
HADOOP-10541.4.patch
>
>
> The same InputStream variable is used for minikdc.ldiff and minikdc-krb5.conf :
> {code}
>     InputStream is = cl.getResourceAsStream("minikdc.ldiff");
> ...
>     is = cl.getResourceAsStream("minikdc-krb5.conf");
> {code}
> Before the second assignment, is should be closed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message