hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10517) InputStream is not closed in two methods of JarFinder
Date Sat, 03 May 2014 03:48:14 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988561#comment-13988561
] 

Hadoop QA commented on HADOOP-10517:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12643174/hadoop-10517-v1.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3905//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3905//console

This message is automatically generated.

> InputStream is not closed in two methods of JarFinder
> -----------------------------------------------------
>
>                 Key: HADOOP-10517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10517
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10517.1.patch.txt, hadoop-10517-v1.txt
>
>
> JarFinder#jarDir() and JarFinder#zipDir() have such code:
> {code}
>                  InputStream is = new FileInputStream(f);
>                  copyToZipStream(is, anEntry, zos);
> {code}
> The InputStream is closed in copyToZipStream() but should be enclosed in finally block.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message