hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10499) Remove unused parameter from ProxyUsers.authorize()
Date Thu, 24 Apr 2014 16:32:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979921#comment-13979921
] 

Ted Yu commented on HADOOP-10499:
---------------------------------

Option #1 doesn't seem feasible.

Option #2 is a good one. That way, developer would check relevant reference in HBase code
before finalizing the change.

> Remove unused parameter from ProxyUsers.authorize()
> ---------------------------------------------------
>
>                 Key: HADOOP-10499
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10499
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 2.4.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Minor
>             Fix For: 3.0.0, 2.5.0
>
>         Attachments: HADOOP-10499.2.patch, HADOOP-10499.patch, HADOOP-10499.patch
>
>
> The Configuration parameter is not used in the authorize() function. It can be removed
and callers can be updated.
> Attaching the simple patch which removes the unused _conf_ parameter and updates the
callers.
> The ProxyUsers is defined as a private audience and so there shouldn't be any external
callers. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message