hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10499) Remove unused parameter from ProxyUsers.authorize()
Date Thu, 24 Apr 2014 16:28:18 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979915#comment-13979915
] 

Chris Nauroth commented on HADOOP-10499:
----------------------------------------

Hi, [~yuzhihong@gmail.com].  Sorry for the inconvenience this caused.  Is it possible to patch
HBase to stop calling the 3-arg form of {{ProxyUsers#authorize}} that was removed?  The third
argument was unused anyway, so this won't change any functionality in HBase.

Additionally, this class is currently annotated {{Private}}, so I expected we didn't need
to check for downstream impacts before I committed.  That means one of two additional changes
needs to happen:
# Change HBase to stop calling {{ProxyUsers#authorize}} altogether.  I'm not really sure what
alternative you would have though, so maybe this isn't feasible.
# Change the annotation to {{LimitedPrivate}} for HBase, so devs know to check for downstream
impacts on interface-breaking changes in the future.

What are your thoughts on this?

> Remove unused parameter from ProxyUsers.authorize()
> ---------------------------------------------------
>
>                 Key: HADOOP-10499
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10499
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 2.4.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Minor
>             Fix For: 3.0.0, 2.5.0
>
>         Attachments: HADOOP-10499.2.patch, HADOOP-10499.patch, HADOOP-10499.patch
>
>
> The Configuration parameter is not used in the authorize() function. It can be removed
and callers can be updated.
> Attaching the simple patch which removes the unused _conf_ parameter and updates the
callers.
> The ProxyUsers is defined as a private audience and so there shouldn't be any external
callers. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message