hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10499) Remove unused parameter from ProxyUsers.authorize()
Date Wed, 16 Apr 2014 21:00:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13971949#comment-13971949
] 

Hadoop QA commented on HADOOP-10499:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12640510/HADOOP-10499.2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs:

                  org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3802//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3802//console

This message is automatically generated.

> Remove unused parameter from ProxyUsers.authorize()
> ---------------------------------------------------
>
>                 Key: HADOOP-10499
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10499
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: 2.4.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Minor
>         Attachments: HADOOP-10499.2.patch, HADOOP-10499.patch, HADOOP-10499.patch
>
>
> The Configuration parameter is not used in the authorize() function. It can be removed
and callers can be updated.
> Attaching the simple patch which removes the unused _conf_ parameter and updates the
callers.
> The ProxyUsers is defined as a private audience and so there shouldn't be any external
callers. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message