hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10472) KerberosAuthenticator should use org.apache.commons.logging.LogFactory instead of org.slf4j.LoggerFactory
Date Tue, 08 Apr 2014 21:51:20 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963489#comment-13963489
] 

Alejandro Abdelnur commented on HADOOP-10472:
---------------------------------------------

What is wrong with using SLF4J? 

The patch as 2 issues, it breaks 7 log statements using message templates (supported by SLF4J),
i.e.:

{code}
      LOG.info("Initialized, principal [{}] from keytab [{}]", principal, keytab);
{code}

You are unnecessary guarding log statements, ie.

{code}
+        if (LOG.isDebugEnabled()) {
+          LOG.debug("Performing our own SPNEGO sequence.");
+        }
{code}


> KerberosAuthenticator should use org.apache.commons.logging.LogFactory instead of org.slf4j.LoggerFactory
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10472
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10472
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HADOOP-10472.000.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message