hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10431) Change visibility of KeyStore KeyVersion/Metadata/Options constructor and methods to public
Date Wed, 09 Apr 2014 22:50:17 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964764#comment-13964764
] 

Alejandro Abdelnur commented on HADOOP-10431:
---------------------------------------------

[~owen.omalley], it is an interface, the fact that the implementation can be remote is just
an implementation detail.

I can use subclasses within other implementations for the Metadata and KeyVersion. It seems
a bit overkilling.

Plus, if you are implementing a KeyProvider that creates a Key, your KeyProvider implementation
does not have access to the Options methods because they are protected (unless you put your
implementation in the same java package as the KeyProvider class). So this has to be fixed.

> Change visibility of KeyStore KeyVersion/Metadata/Options constructor and methods to
public
> -------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10431
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10431
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-10431.patch, HADOOP-10431.patch
>
>
> Making KeyVersion/Metadata/Options constructor and methods public will facilitate {{KeyProvider}}
implementations to use those classes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message