hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo Nicholas Sze (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-10440) HarFsInputStream of HarFileSystem, when reading data, computing the position has bug
Date Wed, 26 Mar 2014 16:46:18 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tsz Wo Nicholas Sze updated HADOOP-10440:
-----------------------------------------

    Hadoop Flags: Reviewed

+1 patch looks good.

> HarFsInputStream of HarFileSystem, when reading data, computing the position has bug
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10440
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10440
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.3.0
>            Reporter: guodongdong
>         Attachments: HADOOP-10440-patch
>
>
> In the HarFsInputStream of HarFileSystem, when reading data by interface "int read(byte[]
b)", "int read(byte[] b, int offset, int len)" wille be called and position wille be update,
so position  need not be update in interface "int read(byte[] b)"
>       public synchronized int read(byte[] b) throws IOException {
>         int ret = read(b, 0, b.length);
>         if (ret != -1) {
>           position += ret;
>         }
>         return ret;
>       }
>       /**
>        *
>        */
>       public synchronized int read(byte[] b, int offset, int len)
>         throws IOException {
>         int newlen = len;
>         int ret = -1;
>         if (position + len > end) {
>           newlen = (int) (end - position);
>         }
>         // end case
>         if (newlen == 0)
>           return ret;
>         ret = underLyingStream.read(b, offset, newlen);
>         position += ret;
>         return ret;
>       }



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message