hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10426) CreateOpts.getOpt(..) should declare with generic type argument
Date Tue, 25 Mar 2014 06:19:51 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13946223#comment-13946223
] 

Junping Du commented on HADOOP-10426:
-------------------------------------

Thanks for this cleanup work, Nicholas! 
+1. patch looks good to me.

> CreateOpts.getOpt(..) should declare with generic type argument
> ---------------------------------------------------------------
>
>                 Key: HADOOP-10426
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10426
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>         Attachments: c10426_20140324.patch
>
>
> Similar to CreateOpts.setOpt(..), the CreateOpts.getOpt(..) should also declare with
a generic type parameter <T extends CreateOpts>.  Then, all the casting from CreateOpts
to its subclasses can be avoided.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message