hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10404) Some accesses to DomainSocketWatcher#closed are not protected by lock
Date Wed, 12 Mar 2014 04:48:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931388#comment-13931388
] 

Ted Yu commented on HADOOP-10404:
---------------------------------

Lgtm

> Some accesses to DomainSocketWatcher#closed are not protected by lock
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-10404
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10404
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: HADOOP-10404.1.patch
>
>
> {code}
>    * Lock which protects toAdd, toRemove, and closed.
>    */
>   private final ReentrantLock lock = new ReentrantLock();
> {code}
> There're two places, NotificationHandler.handle() and kick(), where access to closed
is without holding lock.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message