hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jay vyas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-3679) calls to junit Assert::assertEquals invert arguments, causing misleading error messages, other minor improvements.
Date Wed, 05 Mar 2014 19:10:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921234#comment-13921234
] 

jay vyas commented on HADOOP-3679:
----------------------------------

 looks like i broke TestTFileComparator2.  will look now.  

> calls to junit Assert::assertEquals invert arguments, causing misleading error messages,
other minor improvements.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3679
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3679
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: HADOOP-3679.patch
>
>
> JUnit Assert::assertEquals takes its expected and actual arguments in a particular order,
but many unit tests invert them. The error message from a failed assertion can be misleading.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message