hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-3679) calls to junit Assert::assertEquals invert arguments, causing misleading error messages, other minor improvements.
Date Fri, 14 Mar 2014 01:07:59 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13934397#comment-13934397
] 

Hudson commented on HADOOP-3679:
--------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #5325 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5325/])
HADOOP-3679. Fixup assert ordering in unit tests to yield meaningful error
messages. Contributed by Jay Vyas (cdouglas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1577396)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestStat.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestDataByteBuffers.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestIOUtils.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestText.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/net/TestNetworkTopologyWithNodeGroup.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestGenericsUtil.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestFileHandle.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/nfs/nfs3/TestIdUserGroup.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/test/java/org/apache/hadoop/oncrpc/TestXDR.java


> calls to junit Assert::assertEquals invert arguments, causing misleading error messages,
other minor improvements.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3679
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3679
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Chris Douglas
>            Assignee: jay vyas
>            Priority: Minor
>             Fix For: 3.0.0, 2.4.0
>
>         Attachments: HADOOP-3679.2.patch, HADOOP-3679.3.patch, HADOOP-3679.4.patch, HADOOP-3679.5.patch,
HADOOP-3679.patch
>
>
> JUnit Assert::assertEquals takes its expected and actual arguments in a particular order,
but many unit tests invert them. The error message from a failed assertion can be misleading.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message