hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-3679) calls to junit Assert::assertEquals invert arguments, causing misleading error messages, other minor improvements.
Date Fri, 14 Mar 2014 00:52:43 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Douglas updated HADOOP-3679:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4.0
                   3.0.0
         Assignee: jay vyas
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

+1 I committed this. Thanks Jay

There were still a fair number of whitespace and formatting changes, but they're mostly on
blank lines so I went ahead and pushed it. In future patches, minimizing these preserves history
and reduces noise for reviewers.

> calls to junit Assert::assertEquals invert arguments, causing misleading error messages,
other minor improvements.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3679
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3679
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Chris Douglas
>            Assignee: jay vyas
>            Priority: Minor
>             Fix For: 3.0.0, 2.4.0
>
>         Attachments: HADOOP-3679.2.patch, HADOOP-3679.3.patch, HADOOP-3679.4.patch, HADOOP-3679.5.patch,
HADOOP-3679.patch
>
>
> JUnit Assert::assertEquals takes its expected and actual arguments in a particular order,
but many unit tests invert them. The error message from a failed assertion can be misleading.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message