hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-3679) calls to junit Assert::assertEquals invert arguments, causing misleading error messages, other minor improvements.
Date Fri, 07 Mar 2014 00:48:43 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923328#comment-13923328
] 

Hadoop QA commented on HADOOP-3679:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12633263/HADOOP-3679.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new or modified
test files.

    {color:red}-1 javac{color:red}.  The patch appears to cause the build to fail.

Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3640//console

This message is automatically generated.

> calls to junit Assert::assertEquals invert arguments, causing misleading error messages,
other minor improvements.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3679
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3679
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: HADOOP-3679.2.patch, HADOOP-3679.patch
>
>
> JUnit Assert::assertEquals takes its expected and actual arguments in a particular order,
but many unit tests invert them. The error message from a failed assertion can be misleading.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message