Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C12810B7B for ; Wed, 5 Feb 2014 21:58:28 +0000 (UTC) Received: (qmail 96732 invoked by uid 500); 5 Feb 2014 21:58:23 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 96712 invoked by uid 500); 5 Feb 2014 21:58:22 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 96577 invoked by uid 99); 5 Feb 2014 21:58:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 21:58:14 +0000 Date: Wed, 5 Feb 2014 21:58:14 +0000 (UTC) From: "Andrew Wang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10325) improve jenkins javadoc warnings from test-patch.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892624#comment-13892624 ] Andrew Wang commented on HADOOP-10325: -------------------------------------- +1 pending Jenkins, nice work Colin! I'm looking forward to a more intelligent QA bot. > improve jenkins javadoc warnings from test-patch.sh > --------------------------------------------------- > > Key: HADOOP-10325 > URL: https://issues.apache.org/jira/browse/HADOOP-10325 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: HADOOP-10325.001.patch, HADOOP-10325.002.patch, HADOOP-10325.003.patch, HADOOP-10325.004.patch > > > Currently test-patch.sh uses {{OK_JAVADOC_WARNINGS}} to know how many warnings trunk is expected to have. However, this is a fragile and difficult to use system, since different build slaves may generate different numbers of warnings (based on compiler revision, etc.). Also, programmers must remember to update {{OK_JAVADOC_WARNINGS}}, which they don't always. Finally, there is no easy way to find what the *new* javadoc warnings are in the huge pile of warnings. > We should change this to work the same way the javac warnings code does: to simply build with and without the patch and do a diff. The diff should be saved for easy perusal. We also should not complain about warnings being removed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)