Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7D6C71067B for ; Tue, 4 Feb 2014 00:27:18 +0000 (UTC) Received: (qmail 49495 invoked by uid 500); 4 Feb 2014 00:27:07 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 49383 invoked by uid 500); 4 Feb 2014 00:27:06 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 49357 invoked by uid 99); 4 Feb 2014 00:27:06 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 00:27:06 +0000 Date: Tue, 4 Feb 2014 00:27:06 +0000 (UTC) From: "Chris Li (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-10278) Refactor to make CallQueue pluggable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Li updated HADOOP-10278: ------------------------------ Attachment: HADOOP-10278-atomicref.patch Sure thing, patch updated with atomicref version Potential issue? >From the [BlockingQueue documentation|http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/BlockingQueue.html#poll(long, java.util.concurrent.TimeUnit)]: "drainTo: ...the behavior of this operation is undefined if the specified collection is modified while the operation is in progress." On Performance: * The time can be increased since queue swaps should be rare, maybe even pegged to ipc.client.connect.timeout or made configurable * The performance hit will probably increase with more handler threads too * Even though the server CPU time increased, the throughput wasn't really affected, so it's definitely not the bottleneck (at least not on my machine) > Refactor to make CallQueue pluggable > ------------------------------------ > > Key: HADOOP-10278 > URL: https://issues.apache.org/jira/browse/HADOOP-10278 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc > Reporter: Chris Li > Attachments: HADOOP-10278-atomicref.patch, HADOOP-10278.patch, subtask1.3.patch, subtask1.4.patch, subtask1.5.patch > > > * Refactor CallQueue into an interface, base, and default implementation that matches today's behavior > * Make the call queue impl configurable, keyed on port so that we minimize coupling -- This message was sent by Atlassian JIRA (v6.1.5#6160)