Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B977210AEF for ; Sat, 1 Feb 2014 13:04:12 +0000 (UTC) Received: (qmail 14454 invoked by uid 500); 1 Feb 2014 13:04:11 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 14421 invoked by uid 500); 1 Feb 2014 13:04:10 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 14395 invoked by uid 99); 1 Feb 2014 13:04:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Feb 2014 13:04:09 +0000 Date: Sat, 1 Feb 2014 13:04:09 +0000 (UTC) From: "Steve Loughran (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10085) CompositeService should allow adding services while being inited MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888568#comment-13888568 ] Steve Loughran commented on HADOOP-10085: ----------------------------------------- -I don't agree with adding new states as (a) it adds a lot more complexity and is generally irrelevant. (b) breaks compabitility of an API that is already in use in external applications. You are free to file a JIRA on the topic, but I won't support it. > CompositeService should allow adding services while being inited > ---------------------------------------------------------------- > > Key: HADOOP-10085 > URL: https://issues.apache.org/jira/browse/HADOOP-10085 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 2.2.0 > Reporter: Karthik Kambatla > Assignee: Steve Loughran > Attachments: HADOOP-10085-002.patch, HADOOP-10085-003.patch, HADOOP-10085-004.patch > > > We can add services to a CompositeService. However, if we do that while initing the CompositeService, it leads to a ConcurrentModificationException. > It would be nice to allow adding services even during the init of CompositeService. -- This message was sent by Atlassian JIRA (v6.1.5#6160)