Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0AAF910E80 for ; Tue, 25 Feb 2014 00:42:27 +0000 (UTC) Received: (qmail 41834 invoked by uid 500); 25 Feb 2014 00:42:24 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 41685 invoked by uid 500); 25 Feb 2014 00:42:22 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 41632 invoked by uid 99); 25 Feb 2014 00:42:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2014 00:42:21 +0000 Date: Tue, 25 Feb 2014 00:42:21 +0000 (UTC) From: "jay vyas (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-3679) calls to junit Assert::assertEquals invert arguments, causing misleading error messages MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911048#comment-13911048 ] jay vyas commented on HADOOP-3679: ---------------------------------- Okay, I've done an initial look at this and found {noformat} TestDataByteBuffers TestStat TestIOUtils TestRPC nfs3/TestFileHandle.java util/TestGenericsUtil.java TestNetworkTopologyWithNodeGroup.java TestText.java TestTFileComparator2 TestPath.java TestIdUserGroup.java TestXDR.java {noformat} > calls to junit Assert::assertEquals invert arguments, causing misleading error messages > --------------------------------------------------------------------------------------- > > Key: HADOOP-3679 > URL: https://issues.apache.org/jira/browse/HADOOP-3679 > Project: Hadoop Common > Issue Type: Test > Components: test > Reporter: Chris Douglas > Priority: Minor > > JUnit Assert::assertEquals takes its expected and actual arguments in a particular order, but many unit tests invert them. The error message from a failed assertion can be misleading. -- This message was sent by Atlassian JIRA (v6.1.5#6160)