hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HADOOP-10363) Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null
Date Tue, 25 Feb 2014 04:13:19 GMT
Ted Yu created HADOOP-10363:
-------------------------------

             Summary: Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should
check against null
                 Key: HADOOP-10363
                 URL: https://issues.apache.org/jira/browse/HADOOP-10363
             Project: Hadoop Common
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


Here is related code:
{code}
      try {
        for(in = new SequenceFile.Reader(fs, srcs, job); in.next(key, value); ) {
...
      finally {
        in.close();
      }
{code}
{code}
    SequenceFile.Writer opWriter = null;
    try {
      opWriter = SequenceFile.createWriter(fs, jobconf, opList, Text.class,
          FileOperation.class, SequenceFile.CompressionType.NONE);
...
    } finally {
      opWriter.close();
    }
{code}
If ctor of Reader / Writer throws exception, the close() would be called on null object.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message