hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-10361) Correct alignment in CLI output for ACLs.
Date Tue, 25 Feb 2014 00:38:19 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-10361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated HADOOP-10361:
-----------------------------------

    Attachment: HADOOP-10361.1.patch

This patch corrects 2 small issues:
# Previously, in HADOOP-10270, I had padded with spaces on the line before displaying effective
permissions in getfacl.  On closer inspection of the Linux implementation, I see that this
is really done with a tab character.  I'd like to change our implementation to use a tab for
consistency.
# In HADOOP-10241, we relied on {{FsPermission#toString}} to append '+' to the permission
string if an ACL is present, and we used this detail to determine column alignment.  Since
removal of the ACL bit in HDFS-5923, this alignment logic is no longer correct.  The patch
includes a correction for this.

I updated the ACL CLI tests, and I also tested manually against a cluster built from trunk.

> Correct alignment in CLI output for ACLs.
> -----------------------------------------
>
>                 Key: HADOOP-10361
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10361
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-10361.1.patch
>
>
> This patch will correct a few lingering issues in the alignment of the text output from
the CLI related to ACLs.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message