hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10085) CompositeService should allow adding services while being inited
Date Sun, 02 Feb 2014 18:26:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889006#comment-13889006
] 

Karthik Kambatla commented on HADOOP-10085:
-------------------------------------------

bq. I don't agree with adding new states as (a) it adds a lot more complexity and is generally
irrelevant. (b) breaks compabitility of an API that is already in use in external applications.
You are free to file a JIRA on the topic, but I won't support it.
As I already said in my previous comment, I agree with your assessment here completely. So,
yeah, I was/am not planning to file a JIRA. The JIRA I was filing was to add more tests -
adding a child in every state to a parent in every state. 

The latest patch looks good to me. +1. Committing this.

> CompositeService should allow adding services while being inited
> ----------------------------------------------------------------
>
>                 Key: HADOOP-10085
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10085
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Karthik Kambatla
>            Assignee: Steve Loughran
>            Priority: Blocker
>             Fix For: 2.3.0
>
>         Attachments: HADOOP-10085-002.patch, HADOOP-10085-003.patch, HADOOP-10085-004.patch,
HADOOP-10085-005.patch
>
>
> We can add services to a CompositeService. However, if we do that while initing the CompositeService,
it leads to a ConcurrentModificationException.
> It would be nice to allow adding services even during the init of CompositeService.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message