hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jay vyas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-3679) calls to junit Assert::assertEquals invert arguments, causing misleading error messages
Date Tue, 25 Feb 2014 00:44:19 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911051#comment-13911051
] 

jay vyas commented on HADOOP-3679:
----------------------------------

Shall i start a patch on this ? ^^ It will include reversing assertEquals args for those classes.
 I cant gaurantee that it covers all 1500+ unit tests in the hadoop-common-project, but it
probably gets a large chunk of these errors.  Then maybe the others we can interate on a case
by case basis. 

> calls to junit Assert::assertEquals invert arguments, causing misleading error messages
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3679
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3679
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Chris Douglas
>            Priority: Minor
>
> JUnit Assert::assertEquals takes its expected and actual arguments in a particular order,
but many unit tests invert them. The error message from a failed assertion can be misleading.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message