hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10309) S3 block filesystem should more aggressively delete temporary files
Date Thu, 30 Jan 2014 10:28:09 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886472#comment-13886472
] 

Hadoop QA commented on HADOOP-10309:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12625989/HADOOP-10309.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 1 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3505//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3505//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3505//console

This message is automatically generated.

> S3 block filesystem should more aggressively delete temporary files
> -------------------------------------------------------------------
>
>                 Key: HADOOP-10309
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10309
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/s3
>            Reporter: Joe Kelley
>            Priority: Minor
>         Attachments: HADOOP-10309.patch
>
>
> The S3 FileSystem reading implementation downloads block files into a configurable temporary
directory. deleteOnExit() is called on these files, so they are deleted when the JVM exits.
> However, JVM reuse can lead to JVMs that stick around for a very long time. This can
cause these temporary files to build up indefinitely and, in the worst case, fill up the local
directory.
> After a block file has been read, there is no reason to keep it around. It should be
deleted.
> Writing to the S3 FileSystem already has this behavior; after a temporary block file
is written and uploaded to S3, it is deleted immediately; there is no need to wait for the
JVM to exit.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message