hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haohui Mai (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10232) Fix HttpServer construct
Date Tue, 14 Jan 2014 21:49:25 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13871248#comment-13871248
] 

Haohui Mai commented on HADOOP-10232:
-------------------------------------

{code}
+    private String webapps = WEBAPPS;
+
+
+    public Builder setWebapps(String webapps) {
+      this.webapps = webapps;
+      return this;
+    }
+
+  
+  public String getWebAppsPath(String appName) throws FileNotFoundException {
+      return getWebAppsPath(this.webapps, appName);
+  }
 
{code}

It seems to me that it might not be the right fix. We probably should add a new property {{appDir}}
in the builder and deprecate {{name}}.

{code}
+  public Map<Context, Boolean> getDefaultContexts() {
+      return this.defaultContexts;
+  }
+
+  public Server getWebServer() {
+      return this.webServer;
+  }
{code}

These methods are not supposed to be publicly accessible. Looking at the hbase code, it seems
what you want to do is to override the log servlet. If this is the case, calling {{addServlet}}
on the same path probably can do the trick.


> Fix HttpServer construct
> ------------------------
>
>                 Key: HADOOP-10232
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10232
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Eric Charles
>         Attachments: HDFS-5760-1.patch, HDFS-5760-2.patch
>
>
> o.a.h.h.HttpServer can can be instanciated and configured:
> 1. Via classical constructor
> 2. Via static build method
> Those 2 methods don't populate the same way the (deprecated) hostname and port, nor the
jetty Connector.
> This gives issue when using hbase on hadoop3 (HBASE-6581)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message