hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10208) Remove duplicate initialization in StringUtils.getStringCollection
Date Tue, 07 Jan 2014 06:37:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13863944#comment-13863944

Hadoop QA commented on HADOOP-10208:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 4 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:


    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3405//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3405//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3405//console

This message is automatically generated.

> Remove duplicate initialization in StringUtils.getStringCollection
> ------------------------------------------------------------------
>                 Key: HADOOP-10208
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10208
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>            Priority: Trivial
>         Attachments: HADOOP-10208.patch
> The *values* is initialized twice.
> {code:title=StringUtils.java|borderStyle=solid}
>  public static Collection<String> getStringCollection(String str){
>     List<String> values = new ArrayList<String>();
>     if (str == null)
>       return values;
>     StringTokenizer tokenizer = new StringTokenizer (str,",");
>     values = new ArrayList<String>();
> {code}

This message was sent by Atlassian JIRA

View raw message