Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 393AC10E21 for ; Fri, 20 Dec 2013 02:04:08 +0000 (UTC) Received: (qmail 79547 invoked by uid 500); 20 Dec 2013 02:04:07 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 79510 invoked by uid 500); 20 Dec 2013 02:04:07 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 79464 invoked by uid 99); 20 Dec 2013 02:04:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Dec 2013 02:04:07 +0000 Date: Fri, 20 Dec 2013 02:04:07 +0000 (UTC) From: "Liang Xie (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10169) remove the unnecessary synchronized in JvmMetrics class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853590#comment-13853590 ] Liang Xie commented on HADOOP-10169: ------------------------------------ Yes, you are right, now attached v4 patch. Thanks for review, i really appreciate and enjoy it:) and have learned a lot from those detail code/styles. > remove the unnecessary synchronized in JvmMetrics class > -------------------------------------------------------- > > Key: HADOOP-10169 > URL: https://issues.apache.org/jira/browse/HADOOP-10169 > Project: Hadoop Common > Issue Type: Improvement > Components: metrics > Affects Versions: 3.0.0, 2.2.0 > Reporter: Liang Xie > Assignee: Liang Xie > Priority: Minor > Attachments: HADOOP-10169-v2.txt, HADOOP-10169-v3.txt, HADOOP-10169-v4.txt, HADOOP-10169.txt > > > When i looked into a HBase JvmMetric impl, just found this synchronized seems not essential. -- This message was sent by Atlassian JIRA (v6.1.4#6159)