Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: common-issues@hadoop.apache.org
Date: Thu, 12 Dec 2013 22:43:08 +0000 (UTC)
From: "Brock Noland (JIRA)" <jira@apache.org>
To: common-issues@hadoop.apache.org
Message-ID: <JIRA.12684320.1386872794816.27229.1386888188379@arcas>
In-Reply-To: <JIRA.12684320.1386872794816@arcas>
References: <JIRA.12684320.1386872794816@arcas>
Subject: [jira] [Commented] (HADOOP-10163) Attachment Id for last tested
 patch should be passed to test-patch.sh
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-10163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846844#comment-13846844 ] 

Brock Noland commented on HADOOP-10163:
---------------------------------------

Here is what we do with hive where $JIRA_TEXT is a file containing the entire HTML page:

{noformat}
# pull attachments from JIRA (hack stolen from hadoop since rest api doesn't show attachments)
PATCH_URL=$(grep -o '"/jira/secure/attachment/[0-9]*/[^"]*' $JIRA_TEXT | \
  grep -v -e 'htm[l]*$' | sort | tail -1 | \
  grep -o '/jira/secure/attachment/[0-9]*/[^"]*')
if [[ -z "$PATCH_URL" ]]
then
  echo "Unable to find attachment for $JIRA_NAME"
  exit 1
fi
# ensure attachment has not already been tested
ATTACHMENT_ID=$(basename $(dirname $PATCH_URL))
if grep -q "ATTACHMENT ID: $ATTACHMENT_ID" $JIRA_TEXT
then
  echo "Attachment $ATTACHMENT_ID is already tested for $JIRA_NAME"
  exit 1
fi
{noformat}

> Attachment Id for last tested patch should be passed to test-patch.sh
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-10163
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10163
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ted Yu
>
> In HBASE-10044, attempt was made to filter attachments according to known file extensions.
> However, that change alone wouldn't work because when non-patch is attached, QA bot doesn't provide attachment Id for last tested patch.
> This results in the modified test-patch.sh to seek backward and launch duplicate test run for last tested patch.
> If attachment Id for last tested patch is provided, test-patch.sh can decide whether there is need to run test.


--
This message was sent by Atlassian JIRA
(v6.1.4#6159)