Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B595A109CB for ; Sat, 7 Dec 2013 01:29:35 +0000 (UTC) Received: (qmail 20913 invoked by uid 500); 7 Dec 2013 01:29:35 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 20881 invoked by uid 500); 7 Dec 2013 01:29:35 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 20872 invoked by uid 99); 7 Dec 2013 01:29:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Dec 2013 01:29:35 +0000 Date: Sat, 7 Dec 2013 01:29:35 +0000 (UTC) From: "Ming Ma (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-10106) Incorrect thread name in RPC log messages MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841989#comment-13841989 ] Ming Ma commented on HADOOP-10106: ---------------------------------- Thanks, Sanjay. Moving doRead from Listener class to Reader class is another way to fix the specific issue found. When I was about to revert doRead, I feel like semantically wise it is better to have doRead be a member of Reader. So I includes it as part of the fix. What is the reason to keep doRead method under Listener class? > Incorrect thread name in RPC log messages > ----------------------------------------- > > Key: HADOOP-10106 > URL: https://issues.apache.org/jira/browse/HADOOP-10106 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ming Ma > Priority: Minor > Attachments: hadoop_10106_trunk.patch > > > INFO org.apache.hadoop.ipc.Server: IPC Server listener on 8020: readAndProcess from client 10.115.201.46 threw exception org.apache.hadoop.ipc.RpcServerException: Unknown out of band call #-2147483647 > This is thrown by a reader thread, so the message should be like > INFO org.apache.hadoop.ipc.Server: Socket Reader #1 for port 8020: readAndProcess from client 10.115.201.46 threw exception org.apache.hadoop.ipc.RpcServerException: Unknown out of band call #-2147483647 > Another example is Responder.processResponse, which can also be called by handler thread. When that happend, the thread name should be the handler thread, not the responder thread. -- This message was sent by Atlassian JIRA (v6.1#6144)