hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liang Xie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10169) remove the unnecessary synchronized in JvmMetrics class
Date Fri, 20 Dec 2013 02:04:07 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853590#comment-13853590
] 

Liang Xie commented on HADOOP-10169:
------------------------------------

Yes, you are right, now attached v4 patch.  Thanks for review, i really appreciate and enjoy
it:) and have learned a lot from those detail code/styles.

> remove the unnecessary  synchronized in JvmMetrics class
> --------------------------------------------------------
>
>                 Key: HADOOP-10169
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10169
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>         Attachments: HADOOP-10169-v2.txt, HADOOP-10169-v3.txt, HADOOP-10169-v4.txt, HADOOP-10169.txt
>
>
> When i looked into a HBase JvmMetric impl, just found this synchronized seems not essential.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message