hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Liang Xie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10169) remove the unnecessary synchronized in JvmMetrics class
Date Tue, 17 Dec 2013 08:36:08 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850242#comment-13850242
] 

Liang Xie commented on HADOOP-10169:
------------------------------------

The map gcInfoCache will be filled up once the first getMetrics() be invoked, seems then it'll
be keep unchanged always.
Then during almost of all the life cycle, the gcInfoCache will be read only without any write.
Do we still need the synchronized?
Am i missing sth ?  thanks for taking a look at it:)

> remove the unnecessary  synchronized in JvmMetrics class
> --------------------------------------------------------
>
>                 Key: HADOOP-10169
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10169
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 3.0.0, 2.2.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Minor
>         Attachments: HADOOP-10169.txt
>
>
> When i looked into a HBase JvmMetric impl, just found this synchronized seems not essential.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message