hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mithun Radhakrishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10129) Distcp may succeed when it fails
Date Tue, 26 Nov 2013 19:36:35 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832934#comment-13832934
] 

Mithun Radhakrishnan commented on HADOOP-10129:
-----------------------------------------------

Thanks, Daryn. FWIW, the patch looks good. +1.

Sorry, I thought this was already resolved. I could've sworn I'd posted a fix on another JIRA
to mimick the Y!Internal version's behaviour (i.e. call outstream.close() explicitly).

> Distcp may succeed when it fails
> --------------------------------
>
>                 Key: HADOOP-10129
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10129
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools/distcp
>    Affects Versions: 0.23.0, 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Critical
>         Attachments: HADOOP-10129.patch
>
>
> Distcp uses {{IOUtils.cleanup}} to close its output streams w/o previously attempting
to close the streams.  {{IOUtils.cleanup}} will swallow close or implicit flush on close exceptions.
 As a result, distcp may silently skip files when a partial file listing is generated, and/or
appear to succeed when individual copies fail.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message