hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Loughran (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-10085) CompositeService should allow adding services while being inited
Date Thu, 07 Nov 2013 19:11:17 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steve Loughran updated HADOOP-10085:
------------------------------------

    Attachment: HADOOP-10085-002.patch

This patch adds more tests and fixes the concurrency modification exception that is the core
problem -but the code to test and reject additions in the wrong service state is disabled.

As a result, 3 tests fail, showing cases when a child was added in the wrong state -and the
following transition fails. 

Two fix strategies
# very strict: only allow current state in a service add.
# current or future: you can add INITED, STARTED and STOPPED to a composite in INITED; STARTED
and STOPPED to a STARTED service. I'd argue against adding an INITED before service, because
the child wouldn't share a Configuration instance with all the others

> CompositeService should allow adding services while being inited
> ----------------------------------------------------------------
>
>                 Key: HADOOP-10085
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10085
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Karthik Kambatla
>         Attachments: HADOOP-10085-002.patch
>
>
> We can add services to a CompositeService. However, if we do that while initing the CompositeService,
it leads to a ConcurrentModificationException.
> It would be nice to allow adding services even during the init of CompositeService.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message