hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-10079) log a warning message if group resolution takes too long.
Date Fri, 01 Nov 2013 01:02:02 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810925#comment-13810925
] 

Andrew Wang commented on HADOOP-10079:
--------------------------------------

Looks good, thanks Colin.

* Can you comment on how you chose the default value of 30s?
* Do we need that new {{startMs}} variable when we have already have {{now}} (which could
be renamed {{startMs}}? I don't think the cached check contributes meaningfully compared to
the 30s timeout.
* Also, while we're in this file, how about moving the hardcoded default value of HADOOP_SECURITY_GROUPS_CACHE_SECS
into CommonConfigurationKeys?

> log a warning message if group resolution takes too long.
> ---------------------------------------------------------
>
>                 Key: HADOOP-10079
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10079
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HADOOP-10079.001.patch
>
>
> We should log a warning message if group resolution takes too long.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message