hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
Date Tue, 15 Oct 2013 10:17:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795043#comment-13795043
] 

Hadoop QA commented on HADOOP-9897:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12608461/HADOOP-9897.v3.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.fs.TestPath

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3219//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3219//console

This message is automatically generated.

> Add method to get path start position without drive specifier in o.a.h.fs.Path  
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-9897
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9897
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v3.patch
>
>
> There are a lot of code in Path to get start position after skipping drive specifier,
like:
> {code}
>     int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
> {code}
> Also there is a minor bug in mergePaths:
> mergePath("/", "/foo") will yield Path("//foo") which will be parsed as uri authority,
not path.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message