hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9494) Excluded auto-generated and examples code from clover reports
Date Fri, 04 Oct 2013 19:59:42 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13786558#comment-13786558
] 

Jonathan Eagles commented on HADOOP-9494:
-----------------------------------------

My thoughts on things.

- \*\*/examples/\*\*/\*.java
  this seems fine in general. there are a few tests for functions in these files, but I think
it should not be reported in the tool as lack of coverage for the others. this is probably
fine.
- \*\*/hamlet/\*.java
  not sure this should be excluded since it is not generated. Remove this.
- \*\*/yarn/proto/\*.java
  HSClientProtocol.java does match this but is not generated. this is probably fine.
- \*\*/org/apache/hadoop/yarn/ipc/RpcProtos.java
  RpcProtos.java does not represent a source file or a generated source file in hadoop currently.
Remove this
- security/proto, tools/proto, hs/proto have generated source that is not excluded. Add these.


> Excluded auto-generated and examples code from clover reports
> -------------------------------------------------------------
>
>                 Key: HADOOP-9494
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9494
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.7
>            Reporter: Dennis Y
>         Attachments: HADOOP-9494-trunk--N3.patch, HADOOP-9494-trunk--N4.patch
>
>
> applicable to branch-0.23, branch-2, trunk



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message