hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan A. Veselovsky (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HADOOP-9016) org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream.skip(long) must never return negative value.
Date Wed, 23 Oct 2013 11:41:43 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ivan A. Veselovsky updated HADOOP-9016:
---------------------------------------

    Description: 
The patch fixes bug in method org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream.skip(long):
// the contract is described in java.io.InputStream.skip(long):
// this method returns the number of bytes actually skipped, so,
// the return value should never be negative. 

The patch adds tests for the fixed functionality + other tests to cover other uncovered methods
of classes org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream,
org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream.


  was:
unit-test coverage of classes org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream,
org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream is zero.
Suggested to provide unit-tests covering these classes.

        Summary: org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream.skip(long)
must never return negative value.  (was: Provide unit tests for class org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream
)

> org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream.skip(long) must
never return negative value.
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9016
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9016
>             Project: Hadoop Common
>          Issue Type: Test
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Ivan A. Veselovsky
>            Assignee: Ivan A. Veselovsky
>            Priority: Minor
>         Attachments: HADOOP-9016--b.patch, HADOOP-9016-branch-0.23--d.patch, HADOOP-9016-branch-0.23--e.patch,
HADOOP-9016--c.patch, HADOOP-9016--d.patch, HADOOP-9016--e.patch, HADOOP-9016--f.patch, HADOOP-9016.patch
>
>
> The patch fixes bug in method org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream.skip(long):
> // the contract is described in java.io.InputStream.skip(long):
> // this method returns the number of bytes actually skipped, so,
> // the return value should never be negative. 
> The patch adds tests for the fixed functionality + other tests to cover other uncovered
methods of classes org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream,
> org.apache.hadoop.fs.HarFileSystem.HarFSDataInputStream.HarFsInputStream.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message