Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2852710192 for ; Fri, 27 Sep 2013 06:18:28 +0000 (UTC) Received: (qmail 72599 invoked by uid 500); 27 Sep 2013 06:18:09 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 72562 invoked by uid 500); 27 Sep 2013 06:18:07 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 72536 invoked by uid 99); 27 Sep 2013 06:18:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Sep 2013 06:18:05 +0000 Date: Fri, 27 Sep 2013 06:18:05 +0000 (UTC) From: "Jackie Chang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HADOOP-9995) Consistent log severity level guards and statements MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jackie Chang updated HADOOP-9995: --------------------------------- Description: Developers use logs to do in-house debugging. These log statements are later demoted to less severe levels and usually are guarded by their matching severity levels. However, we do see inconsistencies in trunk. A log statement like if (LOG.isDebugEnabled()) { LOG.info("Assigned container (" + allocated + ") " doesn't make much sense because the log message is actually only printed out in DEBUG-level. We do see previous issues tried to correct this inconsistency. I am proposing a comprehensive correction over trunk. HDFS-1611 also corrected this inconsistency. was: Developers use logs to do in-house debugging. These log statements are later demoted to less severe levels and usually are guarded by their matching severity levels. However, we do see inconsistencies in trunk. A log statement like if (LOG.isDebugEnabled()) { LOG.info("Assigned container (" + allocated + ") " doesn't make much sense because the log message is actually only printed out in DEBUG-level. We do see previous issues tried to correct this inconsistency. I am proposing a comprehensive correction over trunk. > Consistent log severity level guards and statements > ---------------------------------------------------- > > Key: HADOOP-9995 > URL: https://issues.apache.org/jira/browse/HADOOP-9995 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Jackie Chang > Priority: Minor > Attachments: HADOOP-9995.patch > > > Developers use logs to do in-house debugging. These log statements are later demoted to less severe levels and usually are guarded by their matching severity levels. However, we do see inconsistencies in trunk. A log statement like > if (LOG.isDebugEnabled()) { > LOG.info("Assigned container (" + allocated + ") " > doesn't make much sense because the log message is actually only printed out in DEBUG-level. We do see previous issues tried to correct this inconsistency. I am proposing a comprehensive correction over trunk. > HDFS-1611 also corrected this inconsistency. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira