Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F71A10B74 for ; Wed, 4 Sep 2013 13:32:01 +0000 (UTC) Received: (qmail 36543 invoked by uid 500); 4 Sep 2013 13:32:01 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 34548 invoked by uid 500); 4 Sep 2013 13:31:54 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 34202 invoked by uid 99); 4 Sep 2013 13:31:53 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Sep 2013 13:31:53 +0000 Date: Wed, 4 Sep 2013 13:31:53 +0000 (UTC) From: "Hudson (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-9924) FileUtil.createJarWithClassPath() does not generate relative classpath correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757750#comment-13757750 ] Hudson commented on HADOOP-9924: -------------------------------- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1512 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1512/]) HADOOP-9924. FileUtil.createJarWithClassPath() does not generate relative classpath correctly. Contributed by Shanyu Zhao. (ivanmi: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519891) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java > FileUtil.createJarWithClassPath() does not generate relative classpath correctly > -------------------------------------------------------------------------------- > > Key: HADOOP-9924 > URL: https://issues.apache.org/jira/browse/HADOOP-9924 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 2.1.0-beta, 0.23.9 > Reporter: shanyu zhao > Assignee: shanyu zhao > Fix For: 2.1.1-beta > > Attachments: HADOOP-9924-2.patch, HADOOP-9924-3.patch, HADOOP-9924-4.patch, HADOOP-9924.patch > > > On Windows, FileUtil.createJarWithClassPath() is called to generate a manifest jar file to pack classpath - to avoid the problem of classpath being too long. > However, the relative classpath is not handled correctly. It relies on Java's File(relativePath) to resolve the relative path. But it really should be using the given pwd parameter to resolve the relative path. > To reproduce this bug, you can try some pig job on Windows, it will fail and the pig log on the application master will look like this: > 2013-08-29 23:25:55,498 INFO [main] org.apache.hadoop.service.AbstractService: Service org.apache.hadoop.mapreduce.v2.app.MRAppMaster failed in state INITED; cause: org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.RuntimeException: java.lang.ClassNotFoundException: Class org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigOutputFormat not found > org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.RuntimeException: java.lang.ClassNotFoundException: Class org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigOutputFormat not found > This is because the PigOutputFormat class is in the job.jar file but the classpath manifest has: > file:/c:/apps/dist/hadoop-2.1.0-beta/bin/job.jar/job.jar > When it really should be: > file://job.jar/job.jar -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira