hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Eagles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-8704) add request logging to jetty/httpserver
Date Wed, 04 Sep 2013 20:51:56 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758319#comment-13758319
] 

Jonathan Eagles commented on HADOOP-8704:
-----------------------------------------

[~tucu00]. So here is what I found out when looking at whether or not the factory class can
be eliminated easily. Firstly, there are 2 design approaches on the table I debated. 1) Define
one appender in log4j.properties per http server or 2) define one appender shared for all
http servers. I chose the latter since at runtime I can update the filename to include bind
address and port for better use in one node environments (avoiding file naming conflicts among
different http servers). In that design a helper is needed to construct the RequestLog since
the filename isn't fully known without bind address and port. At first I included a static
help function in NCSARequestLogAppender but then found that the helper function could be refactored
out of the class. This leaves an appender class that is very simply to use and simple to test.

So were you thinking it would be better with 1) one appender configuration per http server,
using static filenames, removing the need for a helper construction or 2) consolidate the
factory and the appender class so that the construction help was a static function within
the appender class or 3) something else.

Jon
                
> add request logging to jetty/httpserver
> ---------------------------------------
>
>                 Key: HADOOP-8704
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8704
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.23.3, 2.0.0-alpha
>            Reporter: Thomas Graves
>            Assignee: Jonathan Eagles
>         Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch,
HADOOP-8704.patch
>
>
> We have been requested to log all the requests coming into Jetty/HttpServer for security
and auditing purposes. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message