Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09C4BF92A for ; Tue, 6 Aug 2013 08:58:51 +0000 (UTC) Received: (qmail 42249 invoked by uid 500); 6 Aug 2013 08:58:50 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 41986 invoked by uid 500); 6 Aug 2013 08:58:49 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 41796 invoked by uid 99); 6 Aug 2013 08:58:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Aug 2013 08:58:48 +0000 Date: Tue, 6 Aug 2013 08:58:48 +0000 (UTC) From: "Kousuke Saruta (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HADOOP-9818) Remove usage of "bash -c" from oah.fs.DF MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730545#comment-13730545 ] Kousuke Saruta commented on HADOOP-9818: ---------------------------------------- I'm writing the test for DF and I've noticed things which may be defects. 1. DF#getFilesystem() behaves differently depending on calling the method before / after calling DF#getMount(). I think that is because getMount() calls DF#run() and DF#parseOutput() but getFilesystem() don't. 2. DF#getMount() calls DF#run(). Thus, df command will be executed every we call DF#getMount(). I think it's inefficient. Why only getMount() calls run() in itself? I think run() and parseOutput() should be called in constructor of DF so that df command will be executed when DF is instantiated. > Remove usage of "bash -c" from oah.fs.DF > ---------------------------------------- > > Key: HADOOP-9818 > URL: https://issues.apache.org/jira/browse/HADOOP-9818 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 3.0.0, 2.1.0-beta > Reporter: Andrew Wang > Assignee: Kousuke Saruta > Labels: newbie > Attachments: HADOOP-9818.patch > > > {{DF}} uses "bash -c" to shell out to the unix {{df}} command. This is potentially unsafe; let's think about removing it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira