Return-Path: X-Original-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-common-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C9F8310AAE for ; Thu, 1 Aug 2013 23:33:48 +0000 (UTC) Received: (qmail 94186 invoked by uid 500); 1 Aug 2013 23:33:48 -0000 Delivered-To: apmail-hadoop-common-issues-archive@hadoop.apache.org Received: (qmail 94147 invoked by uid 500); 1 Aug 2013 23:33:48 -0000 Mailing-List: contact common-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: common-issues@hadoop.apache.org Delivered-To: mailing list common-issues@hadoop.apache.org Received: (qmail 94139 invoked by uid 99); 1 Aug 2013 23:33:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2013 23:33:48 +0000 Date: Thu, 1 Aug 2013 23:33:48 +0000 (UTC) From: "Andrew Wang (JIRA)" To: common-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (HADOOP-9818) Remove usage of "bash -c" from oah.fs.DF MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HADOOP-9818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Wang reassigned HADOOP-9818: ----------------------------------- Assignee: Kousuke Saruta Hi Kousuke, thanks for the patch! I've made you a contributor, so now you should be able to assign Common JIRAs to yourself and mark them as Patch Available via the "Submit Patch" button. Part of the trickiness from removing "2>&1" is error handling. I haven't looked into DF at all, but {{ProcessBuilder}} separates stdout and stderr, so stderr messages no longer show up. So, I added another param to {{Shell}} in HADOOP-9652 (hopefully committed soon) which merges them back together. It'd be great if you can review the {{DF}} error handling behavior, especially adding tests for any missing holes you find. > Remove usage of "bash -c" from oah.fs.DF > ---------------------------------------- > > Key: HADOOP-9818 > URL: https://issues.apache.org/jira/browse/HADOOP-9818 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 3.0.0, 2.1.0-beta > Reporter: Andrew Wang > Assignee: Kousuke Saruta > Labels: newbie > Attachments: HADOOP-9818.patch > > > {{DF}} uses "bash -c" to shell out to the unix {{df}} command. This is potentially unsafe; let's think about removing it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira