hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
Date Fri, 23 Aug 2013 19:37:52 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748911#comment-13748911
] 

Chris Nauroth commented on HADOOP-9897:
---------------------------------------

It looks like this patch won't work now that HADOOP-9887 has been committed.  That patch added
another call to {{Path#isWindowsAbsolutePath}}.

This is a public static method on a {{Public}} and {{Stable}} annotated class, so changing
this method signature would be backwards-incompatible.  A safer change would be to handle
this just as an internal refactoring within {{Path}}, and keep the public method signatures
the same.
                
> Add method to get path start position without drive specifier in o.a.h.fs.Path  
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-9897
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9897
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: HADOOP-9897.v1.patch
>
>
> There are a lot of code in Path to get start position after skipping drive specifier,
like:
> {code}
>     int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
> {code}
> Also there is a minor bug in mergePaths:
> mergePath("/", "/foo") will yield Path("//foo") which will be parsed as uri authority,
not path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message