hadoop-common-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HADOOP-9866) convert hadoop-auth testcases requiring kerberos to use minikdc
Date Thu, 15 Aug 2013 23:44:48 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-9866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741681#comment-13741681
] 

Alejandro Abdelnur commented on HADOOP-9866:
--------------------------------------------

Feedback on the patch:

There are several changes which are false changes due to reformatting, please undo all those.

All test methods you are modifying should have a time out: @Test(timeout=####) where ####
is milliseconds. I guess setting them to 1 min should be safe, else set it to 10 times the
time the test takes locally.
 
AuthenticatorTestCase: undo import changes to use class wildcard '*'

KerberosTestUtils: the getKeytabFile() path should be under target now that we create the
keytabs on the fly, doing new File(System.getProperty("build.directory", "target"), UUID.randomUUID())
and creating that dir would do (I believe MiniKDC is using similar logic)

KerberosTestUtils: we can get rid of all the system properties getting of KEYTAB, REALM, CLIENT_PRINCIPAL,
SERVER_PRINCIPAL, KEYTAB_FILE and use hardcoded values as we now do everything within the
MiniKDC scope.

TestKerberosName: if we need keep the krb5.conf file in test/resources  for this test, you'll
have to set/unset the system properties setting the realm/krb5.conf.




                
> convert hadoop-auth testcases requiring kerberos to use minikdc
> ---------------------------------------------------------------
>
>                 Key: HADOOP-9866
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9866
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.3.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Wei Yan
>         Attachments: HADOOP-9866.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message